Fix ScatterChart and RadarChart to refresh when individual data points updated
#5785
+100
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added notifyParent = true to relevant controls in scatter and radar chart implementations to ensure parent widgets are notified of changes in child controls. This improves reactivity and data propagation within chart components.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds notifyParent = true assignments to child controls in radar chart and scatter chart implementations to ensure proper change propagation up the control tree.
- Sets
notifyParenton radar chart data sets, entries, and titles - Sets
notifyParenton scatter chart spots - Aligns these implementations with existing patterns in other chart types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/python/packages/flet-charts/src/flutter/flet_charts/lib/src/utils/radar_chart.dart | Adds notifyParent = true to dataSet, entry, and title controls to propagate changes to parent controls |
| sdk/python/packages/flet-charts/src/flutter/flet_charts/lib/src/scatter_chart.dart | Adds notifyParent = true to spot controls to propagate changes to parent controls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Deploying flet-docs with
|
| Latest commit: |
f37edbf
|
| Status: | ⚡️ Build in progress... |
Tap, secondary tap, and double tap event handlers now receive the last TapDownDetails as event data. This enables more detailed event information to be available for these gesture events. Fix #5784
Introduces handling for tertiary tap down, tap up, long press start, and long press end events in both Dart and Python GestureDetector controls. This enables detection and response to gestures performed with a tertiary button, expanding the range of supported pointer interactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added notifyParent = true to relevant controls in scatter and radar chart implementations to ensure parent widgets are notified of changes in child controls. This improves reactivity and data propagation within chart components.
Summary by Sourcery
Add notifyParent flag to child controls in RadarChart and ScatterChart to ensure parent widgets are updated when individual data points, entries, titles, or spots change, improving chart reactivity.
Bug Fixes: