Skip to content

Conversation

@FeodorFitsner
Copy link
Contributor

@FeodorFitsner FeodorFitsner commented Nov 18, 2025

Updated Control model to avoid treating Uint8List as a generic list. Refactored matplotlib chart examples for consistent import style. Added and updated integration tests and golden images for canvas, including a new test for drawing images from bytes. Also enabled the test for Image control with src_bytes.

Summary by Sourcery

Fix control model list handling for byte arrays, enhance canvas image testing, and refactor example imports for consistency.

Bug Fixes:

  • Exclude Uint8List from generic List transformations in Control model to prevent byte arrays from being misinterpreted

Enhancements:

  • Refactor matplotlib chart example files to use consistent import ordering and f-string formatting

Tests:

  • Add integration test for drawing images from raw bytes on Canvas control
  • Enable and update integration test for Image control using src_bytes

Updated Control model to avoid treating Uint8List as a generic list. Refactored matplotlib chart examples for consistent import style. Added and updated integration tests and golden images for canvas, including a new test for drawing images from bytes. Also enabled the test for Image control with src_bytes.
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@FeodorFitsner FeodorFitsner merged commit 8d492e3 into main Nov 18, 2025
46 of 47 checks passed
@FeodorFitsner FeodorFitsner deleted the fix-decode-src-bytes branch November 18, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants