Declare setuptools as a dependency #628
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flet uses pkg_resources in code, but does not declare the package that provides it as a dependency. While setuptools is populated by default in most virtual environment implementations now, it is continuously being disfavored and is already not present in some tools. This patch properly declares setuptools as a dependency and avoids Flet from crashing in such environments. Since Flet's usage of pkg_resources is quite minimal, it may be worthwhile to eventually move to packaging instead (which pkg_resources vendors), or implement a more lightweight version sorting logic to replace the dependency. The lower version bound is chosen pretty much arbitrarily. Version 56.0.0 is the default setuptools vendored by the standard library's ensurepip module.
|
|
|
You are right, instead of adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flet uses pkg_resources in code, but does not declare the package that provides it as a dependency. While setuptools is populated by default in most virtual environment implementations now, it is continuously being disfavored and is already not present in some tools. This patch properly declares setuptools as a dependency and avoids Flet from crashing in such environments.
Since Flet's usage of pkg_resources is quite minimal, it may be worthwhile to eventually move to packaging instead (which pkg_resources vendors), or implement a more lightweight version sorting logic to replace the dependency.
The lower version bound is chosen pretty much arbitrarily. Version 56.0.0 is the default setuptools vendored by the standard library's ensurepip module.