Skip to content

Added dense property to TextField and Dropdown controls #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Added dense property to TextField and Dropdown controls #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package/lib/src/controls/form_field.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ InputDecoration buildInputDecoration(BuildContext context, Control control,

return InputDecoration(
contentPadding: parseEdgeInsets(control, "contentPadding"),
isDense: control.attrBool("dense"),
label: label != "" ? Text(label) : null,
labelStyle: parseTextStyle(Theme.of(context), control, "labelStyle"),
border: border,
Expand Down
5 changes: 4 additions & 1 deletion sdk/python/flet/dropdown.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
class Dropdown(FormFieldControl):
"""
A dropdown lets the user select from a number of items. The dropdown shows the currently selected item as well as an arrow that opens a menu for selecting another item.

Example:
```
import flet as ft
Expand Down Expand Up @@ -51,6 +51,7 @@ def button_clicked(e):

Online docs: https://flet.dev/docs/controls/dropdown
"""

def __init__(
self,
ref: Optional[Ref] = None,
Expand Down Expand Up @@ -93,6 +94,7 @@ def __init__(
focused_border_width: OptionalNumber = None,
focused_border_color: Optional[str] = None,
content_padding: PaddingValue = None,
dense: Optional[bool] = None,
filled: Optional[bool] = None,
hint_text: Optional[str] = None,
hint_style: Optional[TextStyle] = None,
Expand Down Expand Up @@ -163,6 +165,7 @@ def __init__(
focused_border_width=focused_border_width,
focused_border_color=focused_border_color,
content_padding=content_padding,
dense=dense,
filled=filled,
hint_text=hint_text,
hint_style=hint_style,
Expand Down
11 changes: 11 additions & 0 deletions sdk/python/flet/form_field_control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ def __init__(
focused_border_width: OptionalNumber = None,
focused_border_color: Optional[str] = None,
content_padding: PaddingValue = None,
dense: Optional[bool] = None,
filled: Optional[bool] = None,
hint_text: Optional[str] = None,
hint_style: Optional[TextStyle] = None,
Expand Down Expand Up @@ -142,6 +143,7 @@ def __init__(
self.focused_border_color = focused_border_color
self.content_padding = content_padding
self.filled = filled
self.dense = dense
self.hint_text = hint_text
self.hint_style = hint_style
self.helper_text = helper_text
Expand Down Expand Up @@ -341,6 +343,15 @@ def content_padding(self) -> PaddingValue:
def content_padding(self, value: PaddingValue):
self.__content_padding = value

# dense
@property
def dense(self) -> Optional[bool]:
return self._get_attr("dense")

@dense.setter
def dense(self, value: Optional[bool]):
self._set_attr("dense", value)

# filled
@property
def filled(self) -> Optional[bool]:
Expand Down
5 changes: 4 additions & 1 deletion sdk/python/flet/textfield.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ class TextCapitalization(Enum):
class TextField(FormFieldControl):
"""
A text field lets the user enter text, either with hardware keyboard or with an onscreen keyboard.

Example:
```
import flet as ft
Expand All @@ -94,6 +94,7 @@ def button_clicked(e):

Online docs: https://flet.dev/docs/controls/textfield
"""

def __init__(
self,
ref: Optional[Ref] = None,
Expand Down Expand Up @@ -136,6 +137,7 @@ def __init__(
focused_border_width: OptionalNumber = None,
focused_border_color: Optional[str] = None,
content_padding: PaddingValue = None,
dense: Optional[bool] = None,
filled: Optional[bool] = None,
hint_text: Optional[str] = None,
hint_style: Optional[TextStyle] = None,
Expand Down Expand Up @@ -221,6 +223,7 @@ def __init__(
focused_border_width=focused_border_width,
focused_border_color=focused_border_color,
content_padding=content_padding,
dense=dense,
filled=filled,
hint_text=hint_text,
hint_style=hint_style,
Expand Down