Skip to content

Fix flet pack command on Windows and macOS #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Fix flet pack command on Windows and macOS #795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2d354a
Fix path to an icon
FeodorFitsner Jan 3, 2023
6696e8c
Add `packaging` to dependencies
FeodorFitsner Jan 3, 2023
ea8cdf8
Display original error message
FeodorFitsner Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sdk/python/flet/cli/commands/pack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def handle(self, options: argparse.Namespace) -> None:
if options.icon:
icon_path = options.icon
if not Path(icon_path).is_absolute():
icon_path = Path(os.getcwd()).joinpath(icon_path)
icon_path = str(Path(os.getcwd()).joinpath(icon_path))
update_flet_view_icon(str(exe_path), icon_path)

# version info
Expand Down Expand Up @@ -150,7 +150,7 @@ def handle(self, options: argparse.Namespace) -> None:
if options.icon:
icon_path = options.icon
if not Path(icon_path).is_absolute():
icon_path = Path(os.getcwd()).joinpath(icon_path)
icon_path = str(Path(os.getcwd()).joinpath(icon_path))
update_flet_view_icon(app_path, icon_path)

# version info
Expand All @@ -174,6 +174,6 @@ def handle(self, options: argparse.Namespace) -> None:
):
print("Deleting temp directory:", hook_config.temp_bin_dir)
shutil.rmtree(hook_config.temp_bin_dir, ignore_errors=True)
except ImportError:
print("Please install PyInstaller module to use flet package command.")
except ImportError as e:
print("Please install PyInstaller module to use flet pack command:", e)
exit(1)
2 changes: 1 addition & 1 deletion sdk/python/pdm.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion sdk/python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ dependencies = [
"repath>=0.9.0",
"watchdog>=2.1.9",
"requests>=2.28.1",
"oauthlib>=3.2.0"]
"oauthlib>=3.2.0",
"packaging>=22.0",
]
requires-python = ">=3.7"
license = { text = "MIT" }
classifiers = [
Expand Down