Skip to content

Conversation

@AM1010101
Copy link
Contributor

added property to set transparency of the matplotlib plots
implemented with simple if/else
closed previous pr to update property name to "transparent" instead of "transparency"

@AM1010101
Copy link
Contributor Author

For some background this allows charts to appear like this:
image

instead of like this:
image

@AM1010101
Copy link
Contributor Author

or this:
image

self.__figure.savefig(s, format="svg", transparent=True)
else:
self.__figure.savefig(s, format="svg")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just self.__figure.savefig(s, format="svg", transparent=self.__transparent)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would agree that's better

@FeodorFitsner FeodorFitsner merged commit 982132a into flet-dev:main Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants