fix[notebooks]: fix autograd level set notebook #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaugenst-flex
requested changes
Jan 17, 2025
Contributor
yaugenst-flex
left a comment
yaugenst-flex
left a comment
There was a problem hiding this comment.
Hey @groberts-flex thanks this looks great!
Just very minor comments:
- There are some debugging comments I think left in the notebook (
# does optax convert it to a jax array?) from tidy3d.plugins.autograd.differential_operators import value_and_gradshould work as a top level import sofrom tidy3d.plugins.autograd import value_and_gradwould be preferred- While we're at it, could you run
ruff formaton the notebook? We should start doing this for every notebook.
groberts-flex
force-pushed
the
groberts-flex/fix_level_set_nb
branch
from
face266 to
515293e
Compare
Contributor
Author
|
great, thank you for these comments! think I got all the debugging comments out of there now, fixed the import, and ran ruff format on the notebook file! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates and fixes the autograd level set notebook so that it matches the optimization happening in the adjoint version (with Jax). The major changes were to (1) remove references to the Jax backend and replace with autograd, (2) fix parameters that were set incorrectly, (3) match function calls more correctly between Jax and autograd (i.e. - the np.gradient with a certain mesh size), (4) and fix an underlying bug in the tidy3d codebase to get gradient magnitudes correct in the CustomMedium class (note that an update to the server python code needs to be in effect for this code to run as it does locally).