Skip to content

Add FreqRange examples #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

Add FreqRange examples #327

merged 1 commit into from
Jul 30, 2025

Conversation

@George-Guryev-flxcmp
Copy link
Contributor

@George-Guryev-flxcmp George-Guryev-flxcmp commented Jul 10, 2025

Copied and modified Tidy3D notebooks to demonstrate new FreqRange setup.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025 •
edited
Loading

Spell Check Report

AdiabaticCouplerLN.ipynb:

Cell 6, Line 2: 'one-sided'
  > wvl_width = 0.2  # one-sided wavelength range

Checked 4 notebook(s). Found spelling errors in 1 file(s).
Generated by GitHub Action run: https://github.com/flexcompute/tidy3d-notebooks/actions/runs/16611769710

e-g-melo
e-g-melo approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@e-g-melo e-g-melo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @George-Guryev-flxcmp! Thanks for looking into this!

The changes sound very good to me, and they will be very helpful to our users. I only suggest adding some context about the FreqRange methods and maybe also add a reference to our docs, so that users can find complete information.

tomflexcompute
tomflexcompute approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@tomflexcompute tomflexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @George-Guryev-flxcmp looks great.

@daquinteroflex
Copy link
Collaborator

daquinteroflex commented Jul 22, 2025

Hi is this ready to be merged for 2.9?

@George-Guryev-flxcmp
Copy link
Contributor Author

George-Guryev-flxcmp commented Jul 22, 2025 •
edited
Loading

Hi is this ready to be merged for 2.9?
Have to update notebooks once updated features are merged to /tidy3d (PR #2657).

@daquinteroflex
Copy link
Collaborator

daquinteroflex commented Jul 23, 2025

Oh ok will add the 2.10 label then!

@daquinteroflex daquinteroflex added 2.10 and removed 2.9.0 labels Jul 23, 2025
@George-Guryev-flxcmp George-Guryev-flxcmp merged commit 671c1e7 into develop Jul 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomflexcompute tomflexcompute tomflexcompute approved these changes

@e-g-melo e-g-melo e-g-melo approved these changes

Assignees

No one assigned

Labels

2.10

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@George-Guryev-flxcmp @daquinteroflex @tomflexcompute @e-g-melo