-
Notifications
You must be signed in to change notification settings - Fork 14
adding directional coupler example #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alec-flexcompute
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great example as always, @FilipeFcp! A couple small points:
-
Also mention that you're creating a field monitor to check out the profile in the middle of the waveguides
-
Above cell 9, add "(if the field decays before the runtime, the simulation will auto shut-off and we will only be billed for the Flex credits used to run)" since this will probably be one of the first examples a new user looks at
-
In the interpolation cell, it might be helpful to add a legend in the plot
That's it, thanks for making these examples very easy to review!
e-g-melo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this new notebook @FilipeFcp! It is pretty didactic.
Some suggestions:
- "and create the
td.Structureswith those material properties" -> "and create thetd.Structurewith each of those material properties". - We don't need the plt.show() after sim.plot_3d() in cell [8].
- I suggest using dB in the chart of cell [11] to display the -3dB crossing point. The current method also works, though.
Emerson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FilipeFcp . Definitely make sense to have this addition in the example library.
- The simulation domain size in y can probably be shrunk a bit more to reduce cost?
- In the plotting, does setting
edgecolor="k"actually do anything to the plot? - Might be better to plot transmission as a function of wavelength instead of frequency.
- For printing the transmission, might be better to only show something like 4 significant digits?
- Probably don't need to add the notebook to docs/features/parameter_sweep.rst?
|
Thank you all. I believe everything has been addressed. |
|
Let's merge when ready! |
Spell Check ReportDirectionalCoupler.ipynb: Checked 1 notebook(s). Found spelling errors in 1 file(s). |
Hi all,
I added a quick example using the directional coupler GDS, as @e-g-melo suggested.
Today, I noticed that there's a very similar notebook in the parameter sweep tutorial, so I focused more on the simulation setup and post-processing in this case.
If you have any suggestions to make it more interesting, feel free to let me know!