-
Notifications
You must be signed in to change notification settings - Fork 14
Add PIN Mach-Zehnder notebook #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
alec-flexcompute
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great example @damiano-flex ! A couple notes for publishing the notebook on our website's example conventions:
-
Section headings should have only the first letter capitalized, where usb-headings should have every word capitalized.
-
Below cell 3, "Mobility models Models" -> "Mobility models"
-
Below cell 11, maybe describe around where Fermi Dirac statistics become the more accurate choice
-
Below cell 12, "in particular, an higher refinement..." -> "in particular, a higher refinement..."
-
When running the simulation in cell 16, the logging is quite verbose and should be suppressed
-
In cell 21, I don't think "Eff. DOS - CST" is necessary as a label, but if you want to include it, maybe remind the user what "CST" is
Other than that, looks very informative and useful to users!
|
Thanks @damiano-flex! A few initial comments from me:
|
|
Thanks Damiano for preparing this! Some more concrete comments:
|
5f53c10 to
c04f7af
Compare
dfb017e to
f61b7e2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
This is great! The only thing that I'm missing is a little analysis/description of results (I added some suggestions down below). Other than that just a few minor comments.
|
|
Thanks @damiano-flex looks great. Just some small things:
|
marc-flex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @damiano-flex
I added some minor comments but it's good to go
These seem to be unused
import subprocess
import pandas as pd
import h5pyI would eliminate these sentences:
- **P-Side (right):** Requires **more** bending, creating a positive potential difference.
- **N-Side (left):** Requires **less** bending, creating a negative potential difference.or change them to something like
- **P-Side (right):** Ei bends towards the valence band creating a positive potential difference.
- **N-Side (left):** Ei bends towards the conduction band creating a negative potential difference.I would eliminate section "Comparative plot"
In the sentence
The plots above highligh how the **Constant DOS** model underestimates the number of carrier interactions at high temperatures
highligh -> highlight.
Also it is a bit generic (sounds AI generated). Instead I'd say that since the effective DOS are allowed to change more the resulting increased intrinsic concentration leads to larger currents which result in larger generated heat.
|
I updated the notebook:
The only thing I am missing is a feature picture. Maybe @tomflexcompute can produce it? edit: I am giving it a try with the picture @tomflexcompute |
4dc27d4 to
b7982b6
Compare

This pull request contains a draft version of the PIN Mach-Zehnder notebook.
To better demonstrate the model's capabilities, the electrode temperature has been artificially increased by 50 degrees. This change is intended to showcase the different simulation outcomes between an isothermal analysis, a non-isothermal analysis, and one that accounts for the temperature-dependent effective density of states (DOS).