fix validation of CustomGridBoundaries #2562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Enhanced validation for CustomGridBoundaries to prevent invalid grid specifications and improve error messaging.
- Added coordinate array validation in
tidy3d/components/grid/grid_spec.pyrequiring minimum 2 entries and ascending order - Implemented new test cases in
tests/test_components/test_grid_spec.pyto verify sorting and length requirements - Fixed validator errors reported in SCRF-750 by adding explicit boundary checks for custom grid coordinates
3 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
tylerflex
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
looks good, thanks @dmarek-flex. I'd say that adding the indices like the bot says is probably slightly better and might help in the long run. once that's in feel free to merge.
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changes
Summary
|
dmarek-flex
force-pushed
the
dmarek/fix-custom-grid-validation
branch
from
1092ab1 to
a752f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strange validator errors reported here. So we need better validatation for the
CustomGridBoundaries