fix: disable default low freq smoothing

[dbochkov-flexcompute]

Something that caused issues in notebook. The plan is to take another careful look at it between rc3 and official 2.10, but disable for now

Greptile Overview

Greptile Summary

Disabled default low frequency smoothing in TerminalComponentModeler by changing the low_freq_smoothing field default from ModelerLowFrequencySmoothingSpec() to None.

• Removed the DEFAULT_LOW_FREQUENCY_SMOOTHING_SPEC constant
• Changed default value of low_freq_smoothing field from an instance to None
• Low frequency smoothing can still be explicitly enabled by passing a ModelerLowFrequencySmoothingSpec instance
• The conditional check on line 474 ensures backward compatibility for users who explicitly set this parameter

Confidence Score: 4/5

• This PR is safe to merge with minimal risk as it's a simple default value change
• The change is straightforward and well-contained: removing a default constant and changing a field default from an instance to None. The existing conditional check on line 474 ensures the code handles None gracefully. Score is 4 instead of 5 due to missing changelog entry for this user-facing behavior change.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
tidy3d/plugins/smatrix/component_modelers/terminal.py	4/5	Removed default value for low_freq_smoothing field, changing from ModelerLowFrequencySmoothingSpec() to None

Sequence Diagram

sequenceDiagram
    participant User
    participant TerminalComponentModeler
    participant Simulation
    participant ModeMonitor
    
    User->>TerminalComponentModeler: Create modeler (low_freq_smoothing=None by default)
    TerminalComponentModeler->>TerminalComponentModeler: Check low_freq_smoothing field
    
    alt low_freq_smoothing is None (NEW behavior)
        TerminalComponentModeler->>Simulation: Create simulation without low freq smoothing
        Note over TerminalComponentModeler,Simulation: No extrapolation applied
    else low_freq_smoothing is set
        TerminalComponentModeler->>ModeMonitor: Get mode monitors
        TerminalComponentModeler->>Simulation: Create LowFrequencySmoothingSpec
        TerminalComponentModeler->>Simulation: Apply smoothing to mode monitors
        Note over TerminalComponentModeler,Simulation: Extrapolation applied at low frequencies
    end
    
    Simulation->>User: Return configured simulation

Loading

Context used:

• Rule from dashboard - Require a changelog entry for any PR that is not purely an internal refactor. (source)

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[github-actions]

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

No lines with coverage information in this diff.