-
Notifications
You must be signed in to change notification settings - Fork 66
ci: tidy3d-extras integration tests and docs/dev setup (FXC-4441) #3046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
Diff CoverageDiff: origin/develop...HEAD, staged and unstaged changesNo lines with coverage information in this diff. |
9921fa1 to
a9e8197
Compare
37fca68 to
351ef04
Compare
351ef04 to
75a0f53
Compare
caseyflex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! The docker documentation seems helpful and good to have integration tests. A few comments
.github/workflows/tidy3d-extras-python-client-integration-tests.yml
Outdated
Show resolved
Hide resolved
|
@greptile re review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 files reviewed, no comments
2645fdd to
74a2b41
Compare
|
@caseyflex I've implemented your suggestions and moved the license_test_ci.py to this repo. I'm getting some weird multiplatform errors ( ubuntu and windows are fine, mac are not, maybe it's some issues on tidy3d extras we haven't caught yet? https://github.com/flexcompute/tidy3d/actions/runs/19959108730/job/57234958887 I'll have time to work on this later today but need to do some other stuff for now, just thought to let you know in case it's clearer to you what's going on |
74a2b41 to
ddeb514
Compare
|
@daquinteroflex is it still broken on those platforms? |
|
Yeah haven't been able to get back to it, find it weird it works for ubuntu but not mac if its the same action config? Looks like an issue with the extension? |
Greptile Overview
Greptile Summary
This PR introduces comprehensive Docker development environment improvements and adds integration testing for tidy3d-extras. The changes include expanding the Docker documentation from a minimal 88-line guide to a comprehensive 784-line reference, adding AWS CodeArtifact support to the development container, and establishing dedicated CI workflows for testing tidy3d-extras integration across multiple platforms and Python versions. The enhanced documentation provides step-by-step setup instructions, daily development workflows, VSCode integration, troubleshooting guides, and AWS CodeArtifact access for internal developers. The Docker container improvements add
groff,mandoc, and thepoetry-codeartifact-loginplugin to support better documentation rendering and private package access. The new CI workflow ensures compatibility between the main tidy3d package and its extras components with automated testing across Windows, Ubuntu, and macOS platforms.Important Files Changed
Confidence score: 5/5
Context used:
dashboard- Require a changelog entry for any PR that is not purely an internal refactor. (source)