Skip to content

correct normal for box minimum face in shape gradient #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
groberts-flex wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

correct normal for box minimum face in shape gradient #3050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved performance of adjoint gradient computation for `PolySlab` and `Cylinder` geometries through vectorized sidewall patch collection (~4x speedup).

### Fixed
- Fixed normal for `Box` shape gradient computation to always point outward from boundary which is needed for correct PEC handling.

## [2.10.0rc3] - 2025-11-26

Expand Down
2 changes: 1 addition & 1 deletion tidy3d/components/geometry/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2740,7 +2740,7 @@ def compute_integration_weight(grid_points: NDArray[float]) -> float:
perps1 = np.zeros_like(grid_points)
perps2 = np.zeros_like(grid_points)

normals[:, axis_normal] = 1
normals[:, axis_normal] = -1 if (min_max_index == 0) else 1
perps1[:, axis_perp[0]] = 1
perps2[:, axis_perp[1]] = 1

Expand Down
Loading