Skip to content

Conversation

@momchil-flex
Copy link
Collaborator

@momchil-flex momchil-flex commented Dec 5, 2025

Also piggy-backing removal of one unused argument in the containers monitoring (left over from previous modeler code). @daquintero actrually could you take a look at that code and see if more stuff can be removed now that the postprocess function is integrated with the server call?

Greptile Overview

Greptile Summary

This PR removes all references to the DEVSIM library from the codebase. The changes include removing the devsim dependency from pyproject.toml, updating module docstrings in TCAD components to use more descriptive language, and cleaning up an unused postprocess_worker_group parameter from the Batch.monitor() method.

Key changes:

  • Removed devsim from optional dependencies and all extras groups (dev, docs, heatcharge)
  • Updated docstrings in tidy3d/components/tcad/doping.py and types.py to be more domain-specific
  • Removed unused postprocess_worker_group parameter from Batch.monitor() method in container.py
  • Regenerated poetry.lock file to reflect dependency changes

All changes are safe and straightforward cleanup operations.

Confidence Score: 5/5

  • This PR is safe to merge with no risks - contains only cleanup and documentation changes
  • All changes are simple cleanup operations: dependency removal, docstring updates, and removal of an unused parameter. No logic changes, no breaking changes, and all modifications are backwards compatible. The removed parameter was never used in the function body, and no callers pass this parameter.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
tidy3d/components/tcad/doping.py 5/5 Updated module docstring to remove DEVSIM reference - simple documentation cleanup
tidy3d/components/tcad/types.py 5/5 Updated module docstring to remove DEVSIM reference - simple documentation cleanup
tidy3d/web/api/container.py 5/5 Removed unused postprocess_worker_group parameter from monitor() method - safe cleanup
pyproject.toml 5/5 Removed devsim dependency from optional dependencies and extras - safe cleanup

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Pyproject as pyproject.toml
    participant Container as web/api/container.py
    participant TCAD as tcad/*.py
    
    Dev->>Pyproject: Remove devsim dependency
    Note over Pyproject: Removed from dependencies,<br/>dev extras, docs extras,<br/>and heatcharge extras
    
    Dev->>Container: Remove unused parameter
    Note over Container: Removed postprocess_worker_group<br/>from monitor() signature
    
    Dev->>TCAD: Update docstrings
    Note over TCAD: Changed "DEVSIM case" to<br/>domain-specific descriptions
Loading

@momchil-flex momchil-flex marked this pull request as ready for review December 5, 2025 10:30
Copilot finished reviewing on behalf of momchil-flex December 5, 2025 10:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes all references to the DEVSIM dependency from the codebase and cleans up an unused parameter from the container monitoring functionality.

  • Removes the devsim package dependency from pyproject.toml
  • Updates outdated docstrings to reflect the current HeatCharge solver implementation
  • Removes unused postprocess_worker_group parameter from the Batch.monitor() method

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
tidy3d/web/api/container.py Removes unused postprocess_worker_group parameter from the monitor method signature
tidy3d/components/tcad/types.py Updates module docstring from "DEVSIM case" to "HeatCharge solver associated types"
tidy3d/components/tcad/doping.py Updates module docstring from "DEVSIM case" to "Semiconductor doping definitions"
pyproject.toml Removes devsim from optional dependencies and from dev, docs, and heatcharge extras

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

vtk = ["vtk"]
ruff = ["ruff"]
heatcharge = ["trimesh", "vtk", "devsim"]
heatcharge = ["trimesh", "vtk"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Check that a changelog entry was added for this change - removing devsim from the heatcharge extras is user-facing

Context Used: Rule from dashboard - Require a changelog entry for any PR that is not purely an internal refactor. (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: pyproject.toml
Line: 224:224

Comment:
**style:** Check that a changelog entry was added for this change - removing `devsim` from the `heatcharge` extras is user-facing

**Context Used:** Rule from `dashboard` - Require a changelog entry for any PR that is not purely an internal refactor. ([source](https://app.greptile.com/review/custom-context?memory=b72c7231-b258-4d03-aed2-51a50a9fe757))

How can I resolve this? If you propose a fix, please make it concise.

@momchil-flex momchil-flex changed the title chore: removing devsim mentions FXC-4439: removing devsim mentions Dec 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

No lines with coverage information in this diff.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crazy how big that dependency was then

download_on_success: bool = False,
path_dir: PathLike = DEFAULT_DATA_DIR,
replace_existing: bool = False,
postprocess_worker_group: Optional[str] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@momchil-flex used claude to do a historical search of related changes and it said this was what was leftover from those postprocess changes only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants