refactor(tidy3d): FXC-4436-avoid-ssl-import-for-wasm-build

[marcorudolphflex]

We need to remove the heavy ssl import for the WASM build.
As this is urgent and moving all typing imports behind TYPE_CHECKING is not straightforward with automatic fixes due to pydantic models and the original ssl problem is not solvable by that in general, I decided to only remove this import/type in the config package for now.

Open question: Do we want to extend the except block for all exceptions to catch ssl.SSLError?

Greptile Overview

Greptile Summary

This PR successfully removes the ssl module import from the config package (tidy3d/config/) by changing the ssl_version field from ssl.TLSVersion enum to string-based storage. The implementation includes comprehensive validation that normalizes various TLS version input formats (e.g., "TLS 1.2", "tls1.2", "1.2") into canonical forms (e.g., "TLSv1_2"), and converts back to the enum at the point of use in http_util.py.

• Removed ssl import from tidy3d/config/legacy.py and tidy3d/config/sections.py
• Added robust TLS version validation with regex-based normalization supporting multiple input formats
• Updated type hints from Optional[ssl.TLSVersion] to Optional[str] throughout config modules
• Maintained backward compatibility by accepting ssl.TLSVersion enum objects as input (via .name attribute)
• Added comprehensive test coverage for normalization and validation logic
• Updated existing tests to expect string outputs instead of enum values

Note: Two other files (tidy3d/web/cli/app.py and tidy3d/plugins/dispersion/web.py) still import and catch ssl.SSLError, which relates to the PR author's open question about extending exception handling. These files were not modified in this PR and may need future attention for WASM compatibility.

Confidence Score: 4/5

• This PR is safe to merge with minimal risk, as it maintains backward compatibility and includes comprehensive tests
• Score of 4 reflects a well-implemented refactor with thorough testing. The string-based TLS version storage successfully removes ssl imports from the config package while maintaining full backward compatibility. The validation logic is robust and handles edge cases well. Minor deduction because: (1) there's a theoretical edge case where an invalid string could bypass validation and cause a KeyError in http_util.py (though unlikely with current validation), and (2) the PR doesn't address ssl.SSLError handling in other modules (web/cli/app.py, plugins/dispersion/web.py), though this appears intentional as noted in the PR description.
• No files require special attention - the implementation is solid across all changed files

Important Files Changed

File Analysis

Filename	Score	Overview
tidy3d/config/sections.py	4/5	Added TLS version normalization with string-based storage instead of ssl.TLSVersion enum; comprehensive validation logic handles multiple input formats
tidy3d/web/core/http_util.py	5/5	Converts string TLS version back to ssl.TLSVersion enum when creating SSL context; maintains backward compatibility
tidy3d/config/legacy.py	5/5	Updated type hints from ssl.TLSVersion to str; removed ssl import from legacy config module

Sequence Diagram

sequenceDiagram
    participant User
    participant WebConfig
    participant Validator
    participant HttpUtil
    participant SSLContext

    User->>WebConfig: Set ssl_version="TLS 1.2"
    WebConfig->>Validator: _normalize_ssl_version_name(value)
    Validator->>Validator: Strip spaces & normalize
    Validator->>Validator: Regex match TLS version
    Validator->>Validator: Convert to canonical "TLSv1_2"
    Validator->>Validator: Validate against TLS_VERSION_CHOICES
    Validator-->>WebConfig: Return "TLSv1_2" (string)
    WebConfig-->>User: Store as string

    User->>HttpUtil: Make HTTPS request
    HttpUtil->>WebConfig: Get ssl_version (string)
    WebConfig-->>HttpUtil: "TLSv1_2"
    HttpUtil->>HttpUtil: Convert ssl.TLSVersion["TLSv1_2"]
    HttpUtil->>SSLContext: create_urllib3_context(ssl_version=enum)
    SSLContext-->>HttpUtil: SSL context with TLS 1.2
    HttpUtil-->>User: Execute request with SSL context

Loading

[marcorudolphflex]

@greptile

[greptile-apps]

Additional Comments (1)

1. tidy3d/web/core/http_util.py, line 203 (link)

   logic: create_urllib3_context expects ssl_version to be an ssl.TLSVersion enum or None, not a string. Since config.web.ssl_version is now a string (e.g., "TLSv1_2"), this will cause a TypeError at runtime when TLS version is configured.

   You need to convert the string back to ssl.TLSVersion enum before passing it to create_urllib3_context:

   ssl_version_enum = None
   if config.web.ssl_version:
       ssl_version_enum = getattr(ssl.TLSVersion, config.web.ssl_version, None)
   context = create_urllib3_context(ssl_version=ssl_version_enum)

_{6 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

_{6 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: Potential KeyError if an invalid TLS version string bypasses validation and reaches this point

Suggested change

	ssl_version = (
	ssl.TLSVersion[config.web.ssl_version] if config.web.ssl_version is not None else None
	)
	try:
	ssl_version = (
	ssl.TLSVersion[config.web.ssl_version] if config.web.ssl_version is not None else None
	)
	except KeyError:
	log.warning(f"Invalid TLS version '{config.web.ssl_version}', using default")
	ssl_version = None

Prompt To Fix With AI

This is a comment left during a code review.
Path: tidy3d/web/core/http_util.py
Line: 204:206

Comment:
**style:** Potential `KeyError` if an invalid TLS version string bypasses validation and reaches this point

```suggestion
        try:
            ssl_version = (
                ssl.TLSVersion[config.web.ssl_version] if config.web.ssl_version is not None else None
            )
        except KeyError:
            log.warning(f"Invalid TLS version '{config.web.ssl_version}', using default")
            ssl_version = None
```

How can I resolve this? If you propose a fix, please make it concise.

[github-actions]

Diff Coverage

Diff: origin/develop...HEAD, staged and unstaged changes

• tidy3d/config/legacy.py (100%)
• tidy3d/config/sections.py (100%)
• tidy3d/web/core/http_util.py (33.3%): Missing lines 204,207

Summary

• Total: 31 lines
• Missing: 2 lines
• Coverage: 93%

tidy3d/web/core/http_util.py

Lines 200-211

  200 
  201 
  202 class TLSAdapter(HTTPAdapter):
  203     def init_poolmanager(self, *args: Any, **kwargs: Any) -> None:
! 204         ssl_version = (
  205             ssl.TLSVersion[config.web.ssl_version] if config.web.ssl_version is not None else None
  206         )
! 207         context = create_urllib3_context(ssl_version=ssl_version)
  208         kwargs["ssl_context"] = context
  209         return super().init_poolmanager(*args, **kwargs)
  210 

---