Skip to content

Conversation

@snoe925
Copy link
Contributor

@snoe925 snoe925 commented Oct 21, 2019

Remove using namespace in methods.h header.
The user should get to select the namespace for _1, _2, ...

Remove using namespace in methods.h header.
The user should get to select the namespace for _1, _2, ...
@snoe925 snoe925 requested a review from pm-conej October 21, 2019 20:06
@mutability
Copy link

👍
using namespace should basically never be in headers to avoid this type of problem

Copy link
Contributor

@conej730 conej730 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we just need to see if we can take variable arguments in here

@snoe925 snoe925 merged commit f547585 into master Oct 24, 2019
@snoe925 snoe925 deleted the placeholders branch October 24, 2019 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants