Replace flix-tech/avro-php instead of rg/avro-php to fix critical bug
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bug The bug made it impossible to deserialize binary encoded messages which contained `array` and `map` data types in their schemas
tPl0ch
approved these changes
Nov 17, 2017
Collaborator
tPl0ch
left a comment
tPl0ch
left a comment
There was a problem hiding this comment.
Looks good but we need to do a major version bump since we have changed the dependencies of this library, which means that we have to change the other clients (and there are quite a few of them currently, API, DataBundle) as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
flix-tech/avro-phpinstead ofrg/avro-phpto fix a critical bug.The bug made it impossible to deserialize binary encoded messages
which contained
arrayandmapdata types in their schemas.