support non-root paths in base_uri #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves flix-tech#61 Given a Guzzle client with a base uri like `http://example.com/myregistryliveshere/`. Requests where created with a relative path with a leading `/`. Guzzle interprets this as a path from the root and replaces `/myregistryliveshere/` with the given path. To make Guzzle combine the path correctly with the given base_uri, the relative path must not start with a `/`. Then it is appended at the end of the base_uri, preserving the path in the base_uri.
Collaborator
|
@Yspadadden unfortunately the test cases for the requests are now failing. Would you be able to update the test cases to reflect the changes? |
Contributor
Author
|
I will give it a shot. PHP is not my strong suit. But the failing tests seem fixable. |
After removing the leading "/" from the requests the unit tests failed, because they still expected the leading "/". So removed this from the tests as well to match the code in Functions again.
Collaborator
|
@Yspadadden thanks for your contribution, much appreciated! I will try to release this fix asap. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #61
Given a Guzzle client with a base uri like
http://example.com/myregistryliveshere/.Requests where created with a relative path with a leading
/.Guzzle interprets this as a path from the root and replaces
/myregistryliveshere/with the given path.To make Guzzle combine the path correctly with the given
base_uri, the relative path must not start with a
/. Thenit is appended at the end of the base_uri, preserving the
path in the base_uri.