Feat/querystring filters #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 30, 2021 22:15
…item grid item context
Date range picker and single date picker filters
danilopessoa
requested changes
Apr 14, 2021
| } | ||
| console.log('[EditProcess] props: ', props) | ||
|
|
||
| loadData(props) |
Collaborator
There was a problem hiding this comment.
@tinititus Toda vez que o componente sofrer um atualização ele vai chamar essa função independente de qualquer coisa, isso é o comportamento esperado? Não seria melhor encapsular dentro de um useEffect e executar somente quando necessário?
| const [focusedInput, setFocusedInput] = useState(null) | ||
|
|
||
| const [singleDate, setSingleDate] = useState(null) | ||
| const [focused, setFocused] = useState(false) |
Collaborator
There was a problem hiding this comment.
@tinititus não seria melhor usar somente uma variável de estado para esses controles?
added 6 commits
April 14, 2021 15:58
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A branch contém implementações de duas tasks:
feat/redirect with grid context: Grid na página GeneralStats cujas células podem ser clicadas, redirecionando para a página EditProcess e exibindo o contexto referente à linha da célula clicada, com a query string na barra de endereços;
feat/querystring-filters: Foram adicionados à página GeneralStats componentes TextInput, Dropdown, DateRangePicker e SingleDatePicker cujos inputs são utilizados para formar query strings que são incorporadas à URL da página.
As query strings também são incorporadas às chamadas para a API, que por ora se trata de um mock e por isso não é capaz de retornar o resultado adequado para qualquer consulta.