-
Notifications
You must be signed in to change notification settings - Fork 0
Third party dependency updates #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughScala and sbt plugin versions were bumped: Scala from 2.13.16 to 2.13.17 in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Suggested labels
Suggested reviewers
Pre-merge checks✅ Passed checks (2 passed)
Comment |
|
Click here for code coverage report: https://jenkins.flo.pub/job/flowcommerce/job/lib-util/job/PR-257/3/scoverage-report/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
project/plugins.sbt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Jenkins
🔇 Additional comments (2)
project/plugins.sbt (2)
9-9: PR description is incomplete.The PR description mentions only two dependency updates (scala-reflect and sbt-scalafmt), but the actual changes include a third update: sbt-scoverage from 2.3.1 to 2.4.0. Please update the PR description to accurately reflect all dependency changes.
8-8: Review breaking changes in sbt-scalafmt 2.5.6 and verify sbt-scoverage 2.4.0 version stability.sbt-scalafmt 2.5.6 exists and has no known security vulnerabilities, but the update includes behavior-changing items: scalafmt was bumped to 3.10.0 (affecting formatting output), and there are changes for sbt 2.0.0-RC6 support with deprecated OSS resolvers removed. Verify that your project's formatting and sbt configuration are compatible with these changes.
Additionally, sbt-scoverage 2.4.0 exists in Maven Central but has no official GitHub release or tag; the latest documented release is 2.3.1. Confirm this version is intentional and stable before merging.
About this PR
Updates:
2.13.16to2.13.172.5.5to2.5.6Usage
✅ Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
⚙ Adjust future updates
Add these to your
.scala-steward.conffile to ignore future updates of these dependencies:Or, add these to slow down future updates of these dependencies:
Summary by CodeRabbit