Move bytes field from FlowFile to FlowChunk #195
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
There is clearly a problem. |
Member
|
This is a bug! I think we can merge it since |
Collaborator
|
Sure, but this one won't merge as-is against neither master nor v3. What do you think about renaming the variable ? |
Member
|
we can rename it in v3 branch and this fix should be made in a different commit. We can't rename it on master because it would be a BC |
Member
drzraf
pushed a commit
to drzraf/flow.js
that referenced
this pull request
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bytesfield is in wrong place. This PR fixes it.