Bugfix about fullPath in readDirectory function [#341] #343
+6,612
−6,517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidasK
reviewed
May 31, 2021
| if (entry.isFile) { | ||
| var fullPath = entry.fullPath; | ||
| entry.file((file) => fileReadSuccess(file, fullPath), readError); | ||
| fullPaths[entry.name] = entry.fullPath; |
Member
There was a problem hiding this comment.
won't this create a bug if we have files with the same name on different directories?
Author
There was a problem hiding this comment.
No risk because readDirectory() is called recursively for each directory (so fullPaths is a new empty object each time).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug detailled here:
#341