chunk.abort() to set FlowFile status to "pending" instead of "uploading" #349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 8, 2021 17:51
…its status back to pending (and pendingRetry === true) since it's actually not "uploading" anymore
drzraf
changed the title
Member
|
Looks fine. I would approve this but can't, since I can't find "Approve" button. Please merge it :) |
Collaborator
Author
Why so ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way
abort()can be called on a chunk is by a failure detected by thedoneHandler()In that case, the chunk's
status()would still beuploadingwhat does not keep a retry from happening because it'd skip theuploadNextChunk()codepath.But there is another case which is calling
File.pause()where a call toresume()is expected to go throughuploadNextChunk()which does check chunk'sstatus()ispending. It's also semantically more adequate and that what this PR fixes.This is a requirement for #348 which go deeper into testing pause/resume behaviors.