Skip to content

Conversation

wmedvede
Copy link
Collaborator

* includes: KOGITO-9801: [operator use case] Multiple Workflows with Data Index and Jobs Service

    * includes: KOGITO-9801: [operator use case] Multiple Workflows with Data Index and Jobs Service
@wmedvede wmedvede force-pushed the singleton-jobs-service-per-namespace branch from 92aa488 to 13ac99b Compare September 13, 2023 14:00
Copy link
Contributor

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content!!

periodSeconds: 30
successThreshold: 1
timeoutSeconds: 10
initContainers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, can we use Startup probes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if a startup probe will help here, what we need to check, is that, before the jobs-service initialization begins, the postgres service is available. And this is what the init-postgres init container is trying to do.
But, a startup prob, won't prevent the jobs-service container to wait for the postgres service to start , instead, the jobs-service container will just start, and if the postgres service is not there yet, it'll just fail.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concern is that for prod, we can't use busybox. The Quarkus Health checks won't ping the postgres service?

1. Minikube installed
2. kubectl installed
3. SonataFlow operator installed if workflows are deployed

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the following:

The minikube registry addon must be enabled in order for the workflow images to get stored in the local registry of the container.

minikube addons enable registry 

To confirm that the add is enabled:

minikube addons list |grep registry
| registry                    | minikube | enabled ✅   | minikube                       |
| registry-aliases            | minikube | disabled     | 3rd party (unknown)            |
| registry-creds              | minikube | disabled     | 3rd party (UPMC Enterprises)   |

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardozanini sounds good. I will submit a PR for it.

@wmedvede
Copy link
Collaborator Author

@ricardozanini The suggestions were added, regarding the startup probe I left a comment, take look please.

@ricardozanini
Copy link
Contributor

Let's merge it for now since many people are looking for this change. We can try another approach for the startup when implementing the Data Index/Jobs Service controllers in the operator that won't rely on busybox. cc @tchughesiv

@ricardozanini ricardozanini merged commit bb32134 into flows-examples:main Sep 15, 2023
@wmedvede wmedvede deleted the singleton-jobs-service-per-namespace branch May 18, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants