This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Ephemeral networks core implementation #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsartem
reviewed
Jul 27, 2022
shamsartem
reviewed
Aug 4, 2022
shamsartem
approved these changes
Aug 5, 2022
src/internal/FluencePeer.ts
Outdated
Comment on lines
422
to
424
| if (!config.KeyPair) { | ||
| throw new Error('Key Pair is required'); | ||
| } |
There was a problem hiding this comment.
When you added the type & Required<Pick<PeerConfig, 'KeyPair'>> above you removed the necessety for this run time if (!config.KeyPair) check. Please remove it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.