This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Migrate to monorepo and pnpm #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will become non-draft once the CI work |
nahsi
reviewed
Aug 24, 2022
nahsi
reviewed
Aug 24, 2022
nahsi
reviewed
Aug 24, 2022
nahsi
reviewed
Aug 24, 2022
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: |
There was a problem hiding this comment.
Do we really need a snapshot on every push to github? Perhaps it would be better to set it to workflow_dispatch and use that when you need a snapshot?
There was a problem hiding this comment.
Since we are pushing to our internal registry I think it would be harmless. It's kind tedious when you are integrating your changes (e.g into aqua-playground ) and have to trigger the workflow for every commit
There was a problem hiding this comment.
We decided to leave it as is for now
DieMyst
approved these changes
Aug 24, 2022
Co-authored-by: Anatoly Laskaris <github_me@nahsi.dev>
Co-authored-by: Anatoly Laskaris <github_me@nahsi.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PR single package is split into multi package monorepo manages by pnpm. The core FluenceJS no longer depends on the exact implementations for libp2p and keypair related stuff. Instead necessary functionality was interfaced away and taken out to separate packages.
The new package structure is:
@fluencelabs/fluence- the main package as before the update.@fluencelabs/interfaces- common interfaces for FluenceJS@fluencelabs/connection- connectivity layer, i.e FluenceConnection@fluencelabs/keypair- implementation of keypairpnpm takes care of the monorepo pretty well. Basically you just prefix the dependency with
workspace:and then specify the version as you normally would. pnpm will figure out the appropriate source for the package and use it accordingly. Also it makes releases very simple by replacing the prefix with the appropriate version when creating packages.These changes are needed for the subsequent update to libp2p v0.37.x as well as adding more tests for different environments in future.