Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Conversation

@nahsi
Copy link
Contributor

@nahsi nahsi commented Sep 3, 2022

  • Deduplicate by using same workflow locally and from other repositories with workflow_call
  • Run tests on PR event not push
  • Build snapshot and run aqua-playground tests with it
  • Add comment to PR with fluence-js version

@nahsi nahsi marked this pull request as ready for review September 6, 2022 09:34
@nahsi nahsi requested a review from coder11 September 6, 2022 09:34
@nahsi nahsi changed the title Add workflow_call to run_tests Use workflow_call to run tests/publish build snapshot and add E2E Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

FluenceJS version is 0.24.1-tests-workflow-call-7f72894-15-1

To install it run:

npm login --registry https://npm.fluence.dev
npm i @fluencelabs/fluence@0.24.1-tests-workflow-call-7f72894-15-1 --registry=https://npm.fluence.dev

@nahsi nahsi requested a review from coder11 September 6, 2022 12:57
@nahsi nahsi force-pushed the tests-workflow-call branch from 85d0cb6 to c1bf9ac Compare September 6, 2022 13:47
issue-number: "${{ github.event.pull_request.number }}"
edit-mode: replace
body: |
## FluenceJS version is [${{ env.FLUENCE_JS_VERSION }}](https://npm.fluence.dev/-/web/detail/@fluencelabs/fluence/v/${{ env.FLUENCE_JS_VERSION }})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just so awesome!

with:
node-version: ${{ matrix.node-version }}

- run: pnpm i
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not having all three inside a single step?

@coder11 coder11 self-requested a review September 6, 2022 14:40
@nahsi nahsi merged commit b68d610 into master Sep 6, 2022
@nahsi nahsi deleted the tests-workflow-call branch September 6, 2022 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants