This repository was archived by the owner on Jul 10, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
Use workflow_call to run tests/publish build snapshot and add E2E #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coder11
approved these changes
Sep 6, 2022
* Try to run e2e with aqua-playground * Fixes
run_tests
FluenceJS version is 0.24.1-tests-workflow-call-7f72894-15-1To install it run: npm login --registry https://npm.fluence.dev
npm i @fluencelabs/fluence@0.24.1-tests-workflow-call-7f72894-15-1 --registry=https://npm.fluence.dev |
nahsi
commented
Sep 6, 2022
85d0cb6 to
c1bf9ac
Compare
coder11
reviewed
Sep 6, 2022
| issue-number: "${{ github.event.pull_request.number }}" | ||
| edit-mode: replace | ||
| body: | | ||
| ## FluenceJS version is [${{ env.FLUENCE_JS_VERSION }}](https://npm.fluence.dev/-/web/detail/@fluencelabs/fluence/v/${{ env.FLUENCE_JS_VERSION }}) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just so awesome!
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
|
|
||
| - run: pnpm i |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not having all three inside a single step?
coder11
approved these changes
Sep 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workflow_call