This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Accommodate new marine-js and avm interface #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FluenceJS version is 0.25.0-new-marine-avm-interface-e9dd423-22-1To install it run: npm login --registry https://npm.fluence.dev
npm i @fluencelabs/fluence@0.25.0-new-marine-avm-interface-e9dd423-22-1 --registry=https://npm.fluence.dev |
shamsartem
reviewed
Sep 12, 2022
shamsartem
reviewed
Sep 12, 2022
Comment on lines
+622
to
+623
| avmCallResult = e instanceof Error ? e : new Error((e as any).toString()); | ||
| } |
Contributor
There was a problem hiding this comment.
not critical of course, but I think there is no need for a separate newData variable
Contributor
Author
There was a problem hiding this comment.
This was left intentionally to show what is being swapped with what. Otherwise is hard to track what is data, prevdata and newdata
shamsartem
reviewed
Sep 12, 2022
shamsartem
reviewed
Sep 12, 2022
shamsartem
reviewed
Sep 12, 2022
| return { | ||
| retCode: ResultCodes.success, | ||
| result: result as JSONValue, | ||
| }; |
Contributor
There was a problem hiding this comment.
I think in the furture we should get rid of the typecasts because who knows what data can be sent by bad actors - I think everything should be checked and acted apon appropriatly instead of just failing
shamsartem
approved these changes
Sep 12, 2022
Contributor
shamsartem
left a comment
shamsartem
left a comment
There was a problem hiding this comment.
Thanks for the work!
Not sure, if I understand everything correctly, but the code itself seems fine
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.