This repository was archived by the owner on Jul 10, 2025. It is now read-only.
Allow ws transport #37
Merged
+56
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coder11
approved these changes
Apr 12, 2021
Contributor
coder11
left a comment
coder11
left a comment
There was a problem hiding this comment.
Need to fix the test and address the comments
| "test:all": "jest", | ||
| "test:unit": "jest --testPathPattern=src/__test__/unit", | ||
| "test:integration": "jest --testPathPattern=src/__test__/integration", | ||
| "test": "jest --env=jsdom --watch", |
Contributor
There was a problem hiding this comment.
that's strange. jsom should be the default option
Contributor
Author
There was a problem hiding this comment.
I've added it just in case. Explicit here is better than implicit I think. I also think that we should run tests for both env node and env jsdom
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.