This repository was archived by the owner on Jul 10, 2025. It is now read-only.
chore: Review fixes at #378 #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsartem
reviewed
Nov 21, 2023
Comment on lines
454
to
455
| console.log(avmCallResult.callRequests, "call requiest"); | ||
| console.log(avmCallResult.nextPeerPks, "call requiest"); |
Contributor
There was a problem hiding this comment.
maybe debug log is better if you want to log something?
Contributor
Author
There was a problem hiding this comment.
thanks, i forgot to remove them
shamsartem
reviewed
Nov 22, 2023
| async sign({ | ||
| args: [data], | ||
| context, | ||
| }: MethodArgs<[number[]]>): Promise<SignReturnType> { |
Contributor
There was a problem hiding this comment.
I think that's pretty nice to work with now, thanks. I would only suggest to rename this to maybe ServiceFnArgs since these are supposed to be built-in service functions
shamsartem
reviewed
Nov 22, 2023
| // This wrong type comes from aqua team. We need to discuss fix with them | ||
| // eslint-disable-next-line @typescript-eslint/consistent-type-assertions | ||
| (srvDef.defaultServiceId as DefaultServiceId).s_Some__f_value != null | ||
| srvDef.defaultServiceId != null |
Contributor
There was a problem hiding this comment.
I think it's tiny bit simpler if negation is used as rarely as possible (except for maybe some early returns or errors)
Suggested change
| srvDef.defaultServiceId != null | |
| srvDef.defaultServiceId == null ? functionOverloadsWithoutDefaultServiceId : functionOverloadsWithDefaultServiceId |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.