This repository was archived by the owner on Jul 10, 2025. It is now read-only.
fix: Enable async loading of all dependency resources #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamsartem
approved these changes
Dec 26, 2023
Contributor
shamsartem
left a comment
shamsartem
left a comment
There was a problem hiding this comment.
If it's doing the job for now it's fine. Would appreciate if a task is created to at least think about a better solution if you have something in mind
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
I grouped worker initiation with spawning to prevent unexpected bug. The bug is occurring when there is some time window between worker initiation and call to
spawnfunction. More expensive solution is to put some effort in fixing that, but easier one is to group that code together.