Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Conversation

@coder11
Copy link
Contributor

@coder11 coder11 commented May 4, 2021

Migration to the new package format.

See: fluencelabs/aquavm#98

WIP status will be lifted once the new package format will be released and I change the dependency

@coder11 coder11 requested a review from DieMyst May 4, 2021 10:29
@coder11 coder11 marked this pull request as ready for review May 5, 2021 13:03
@coder11 coder11 force-pushed the update-air branch 2 times, most recently from 78a850e to ed72ee8 Compare May 11, 2021 13:11
@coder11 coder11 requested a review from folex May 11, 2021 13:37
@@ -0,0 +1,39 @@
name: Run tests in jsdom environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it is possible to utilize strategy: matrix: to have all tests in a single file.

Copy link
Contributor

@folex folex May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like this:

jobs:
    build:
        runs-on: ubuntu-latest

        strategy:
            matrix:
                node-version: [14.x, 15.x]
                environment: ["jsdom", "node"]
...

            - run: npm install
            - run: npm run test:${{ matrix.environment }}:all
              env:
                  CI: true

It should trigger 2*2 = 4 test runs. The only change package.json would be to have the following scripts:

  • npm run test:jsdom:all
  • npm run test:node:all

@coder11 coder11 merged commit 9aa077e into master May 11, 2021
@coder11 coder11 deleted the update-air branch June 7, 2021 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants