Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Conversation

@coder11
Copy link
Contributor

@coder11 coder11 commented Jun 3, 2021

No description provided.

@coder11 coder11 requested a review from folex June 3, 2021 16:30

describe('Tests for default handler', () => {
// prettier-ignore
each`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, cool :)

return;

case 'bytes_to_b58':
const array = req.args[0] as number[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe assert that args[0] is array of numbers and return error if not?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hhm, nice idea

return;

case 'bytes_from_b58':
const ba = decode(req.args[0]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@coder11 coder11 merged commit 53385c5 into master Jun 3, 2021
@coder11 coder11 deleted the implement-builtins branch June 7, 2021 13:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants