Skip to content
This repository was archived by the owner on Jul 10, 2025. It is now read-only.

Conversation

@coder11
Copy link
Contributor

@coder11 coder11 commented Jun 8, 2021

Fixes #49

@coder11 coder11 requested a review from folex June 8, 2021 16:38
Copy link
Contributor

@folex folex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More types! Awesome! :)

});

if (res.result === undefined) {
log.error('Call service unexpectedly returned undefined result, falling back to null');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you plz add serviceId and fnName to the error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! Done

@coder11 coder11 requested a review from folex June 8, 2021 19:15
@coder11 coder11 merged commit cabbe89 into master Jun 9, 2021
@coder11 coder11 deleted the fix-undefined-in-vars branch July 29, 2021 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Passing undefined value to withVariables causes an unhandled exception

3 participants