This repository was archived by the owner on May 22, 2025. It is now read-only.
Missing capability method getAvailableEncoders #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhodgkins
force-pushed
the
missing-capabilities
branch
from
180452b to
63b603d
Compare
Contributor
Author
|
Not sure why the build is failing - its happening on the other 2 pull requests occasionally too 😔 |
Member
|
Yeah, that's due to some timing-dependent tests that I wasn't able to rewrite correctly. |
njoyard
suggested changes
Apr 23, 2017
Member
njoyard
left a comment
njoyard
left a comment
There was a problem hiding this comment.
Cool, we're just missing a test here (test/capabilities.test.js:131)
rhodgkins
force-pushed
the
missing-capabilities
branch
from
3f2034a to
119a277
Compare
Contributor
Author
|
👍 done! Any chance when merging this in that you could also push a new version to npm? |
Member
|
Yep. Do you have an account on npmjs.org ? |
Contributor
Author
|
Yep - rhodgkins |
Member
|
Okay, added you on npmjs so that you can push the new version if you want to. I won't be able to do it myself for a few days. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add both
getAvailableEncodersandavailableEncoders.