Skip to content

Conversation

illescad
Copy link

Support for opensuse-leap 15.6 and sles 15.7 pacakging. See fluent-bit/10978 for implementation, resolves #10875

Signed-off-by: Dan Illescas <daniel.illescas@hpe.com>
Copy link
Contributor

@esmerel esmerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some consistency suggestions which will fix some of the vale warnings.

I also updated the vale test so that SUSE/SLES shouldn't give warnings anymore, but those are in master so this branch is still going to have the warnings but won't after merging (or if it's rebased).

Comment on lines 46 to 48
$ sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-* && \

$ sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-* && \
$ sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-*
sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-* && \
sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-*


For openSUSE and SUSE Linux Enterprise Server (SLES)

Fluent Bit provides packages for openSUSE (Leap) and SUSE Linux Enterprise Server (SLES). The repository uses the $releasever variable to dynamically fetch packages for your specific system version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Fluent Bit provides packages for openSUSE (Leap) and SUSE Linux Enterprise Server (SLES). The repository uses the $releasever variable to dynamically fetch packages for your specific system version.
Fluent Bit provides packages for openSUSE (Leap) and SUSE Linux Enterprise Server (SLES). The repository uses the `$releasever` variable to dynamically fetch packages for your specific system version.

Signed-off-by: Dan Illescas <daniel.illescas@hpe.com>
@illescad
Copy link
Author

@esmerel thanks for your review and suggestions. i just pushed changes for suse.md. I had left a draft version of that file in by accident

Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a very small nitpick. Could you check it?

…onfusion and issues going forward

Signed-off-by: Dan Illescas <daniel.illescas@hpe.com>
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For technical terminology, it looks good to me.

@eschabell
Copy link
Collaborator

@esmerel the vale lint failed, is this a blocker or just a run failure, can you check?

I'm nudging on the code PR side (2x) to get this completed.

@eschabell eschabell self-assigned this Oct 21, 2025
@eschabell eschabell added the waiting-on-review Waiting on a review from mainteners label Oct 21, 2025
Signed-off-by: Lynette  Miles <6818907+esmerel@users.noreply.github.com>
@esmerel
Copy link
Contributor

esmerel commented Oct 21, 2025

@eschabell I pushed a bunch of vale corrections - the one that test is failing on won't (or at least shouldn't) block the merge, you can still merge even though the button isn't green. In this case it's a test that needed an update to account for the capitalization, which I already fixed in main. I have no issues merging this PR as it is.

@eschabell eschabell removed the waiting-on-review Waiting on a review from mainteners label Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add suse and sles as packing/distros

5 participants