-
Notifications
You must be signed in to change notification settings - Fork 538
packaging: add opensuse and sles #2103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Dan Illescas <daniel.illescas@hpe.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some consistency suggestions which will fix some of the vale warnings.
I also updated the vale test so that SUSE/SLES shouldn't give warnings anymore, but those are in master so this branch is still going to have the warnings but won't after merging (or if it's rebased).
installation/downloads/linux/suse.md
Outdated
$ sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-* && \ | ||
|
||
$ sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-* && \ | |
$ sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-* | |
sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-* && \ | |
sed -i 's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g' /etc/yum.repos.d/CentOS-* |
installation/downloads/linux/suse.md
Outdated
|
||
For openSUSE and SUSE Linux Enterprise Server (SLES) | ||
|
||
Fluent Bit provides packages for openSUSE (Leap) and SUSE Linux Enterprise Server (SLES). The repository uses the $releasever variable to dynamically fetch packages for your specific system version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fluent Bit provides packages for openSUSE (Leap) and SUSE Linux Enterprise Server (SLES). The repository uses the $releasever variable to dynamically fetch packages for your specific system version. | |
Fluent Bit provides packages for openSUSE (Leap) and SUSE Linux Enterprise Server (SLES). The repository uses the `$releasever` variable to dynamically fetch packages for your specific system version. |
Signed-off-by: Dan Illescas <daniel.illescas@hpe.com>
@esmerel thanks for your review and suggestions. i just pushed changes for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a very small nitpick. Could you check it?
…onfusion and issues going forward Signed-off-by: Dan Illescas <daniel.illescas@hpe.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For technical terminology, it looks good to me.
@esmerel the vale lint failed, is this a blocker or just a run failure, can you check? I'm nudging on the code PR side (2x) to get this completed. |
Signed-off-by: Lynette Miles <6818907+esmerel@users.noreply.github.com>
@eschabell I pushed a bunch of vale corrections - the one that test is failing on won't (or at least shouldn't) block the merge, you can still merge even though the button isn't green. In this case it's a test that needed an update to account for the capitalization, which I already fixed in main. I have no issues merging this PR as it is. |
Support for opensuse-leap 15.6 and sles 15.7 pacakging. See fluent-bit/10978 for implementation, resolves #10875