Completed configuration options for source build doc. Fixes #2134. #2145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rations. Signed-off-by: Eric D. Schabell <eric@schabell.org>
Signed-off-by: Eric D. Schabell <eric@schabell.org>
… build doc. Applys to fluent#1386. Signed-off-by: Eric D. Schabell <eric@schabell.org>
… build doc. Applys to fluent#2134. Signed-off-by: Eric D. Schabell <eric@schabell.org>
…ent-bit-docs-fork into erics_source_build_options
…or source build doc. Applys to fluent#2134. Signed-off-by: Eric D. Schabell <eric@schabell.org>
Signed-off-by: Eric D. Schabell <eric@schabell.org>
Collaborator
Author
|
@esmerel can you review please, but see comment above? |
Signed-off-by: Eric D. Schabell <eric@schabell.org>
Collaborator
Author
|
@cosmo0920 can you review this for build option accuracy, I went through it all based on the available code options, but would like you to verify? |
patrick-stephens
approved these changes
Nov 5, 2025
Contributor
patrick-stephens
left a comment
patrick-stephens
left a comment
There was a problem hiding this comment.
I am of the opinion that this looks good and we should merge now then just resolve any issues raised directly.
One thing we should indicate is the implicit disabling of requested options when dependencies are missing - this is not consistent and can break things without you realising.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed configuration options for source build doc. Fixes #2134.
Note to reviewers:
The file with changes contains links to docs for the plugins listed, with a few using yet to be made docs. Each of these docs has an open issue and i plan to work through them next. I would like these incorrect (not available) links to be in place now for the fixes I'm rolling out next to save time revisiting them.