Node v14+ support and fix for TypeScript and EventEmitter

[fidian]

Node v14 is the active LTS and it switches to "maintenance" tomorrow, making Node v16 the current LTS as of Tuesday. It would be great to be able to upgrade the project so it builds without errors. When I try, I get the following:

node_modules/@fluent-org/logger/build/src/server.d.ts:63:43 - error TS2507: Type 'typeof EventEmitter' is not a constructor function type.

63 export declare class FluentServer extends EventEmitter {
                                             ~~~~~~~~~~~~

node_modules/@fluent-org/logger/build/src/socket.d.ts:164:43 - error TS2507: Type 'typeof EventEmitter' is not a constructor function type.

164 export declare class FluentSocket extends EventEmitter {
                                              ~~~~~~~~~~~~


Found 2 errors.

From what I see at DefinitelyTyped, the upgrade at 13.4 or 13.5 caused issues. Geckos.io has a simple fix, as does cheap-watch. It basically means you have to change the import line.

// Old
import * as EventEmitter from "events";

// New
import { EventEmitter } from 'events';

[fidian]

I have tested modifying files as a part of my build script, which probably isn't the best way to do things.

{
    ....
    "scripts": {
        "build": "npm run fix-fluent-logger && tsc",
        "fix-fluent-logger": "perl -pi -e 's/\\* as EventEmitter/\\{EventEmitter\\}/' node_modules/@fluent-org/logger/build/src/*.d.ts",
        ...
    },
    ...
}

On my fork, I tried to make the minimal amount of changes in order to have the project work. I didn't have yarn installed, so it was added to package.json, then I made the changes for EventEmitter, then finally I had to type a few caught exceptions. Feel free to pull in any portions you want from https://github.com/fidian/fluent-logger-forward-node.

[jamiees2]

Sorry for taking so long on this, I finally found some time, and addressed this in the recently cut v1.0.4 :) Let me know if that works for you!

[tance77]

This still seems to be an issue in node 16. Was this fixed?

TypeError: EventEmitter is not a constructor at node_modules/jsforce/lib/core.js