Fix finally usage #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Elias Sigurdarson <jamiees2@gmail.com>
jamiees2
force-pushed
the
fix-finally
branch
from
1428e39 to
7c96ff5
Compare
Signed-off-by: James Elias Sigurdarson <jamiees2@gmail.com>
Signed-off-by: James Elias Sigurdarson <jamiees2@gmail.com>
github-actions bot
added a commit
that referenced
this pull request
Feb 11, 2022
* fix finally usage Signed-off-by: James Elias Sigurdarson <jamiees2@gmail.com> * also wrap in block Signed-off-by: James Elias Sigurdarson <jamiees2@gmail.com> * fix test Signed-off-by: James Elias Sigurdarson <jamiees2@gmail.com> * forgot to save Signed-off-by: James Elias Sigurdarson <jamiees2@gmail.com> 3410898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promise.prototype.finallywill rethrow the error that caused it to be called in a new promise, so we need to make sure to either handle it, or pass it on to the caller to handle.Fixes #28