Fix unhandled rejection #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiees2
force-pushed
the
fix-unhandled
branch
from
8b852a1 to
957fe1a
Compare
Signed-off-by: James Elias Sigurdarson <jamiees2@gmail.com>
jamiees2
force-pushed
the
fix-unhandled
branch
from
957fe1a to
8e9b789
Compare
github-actions bot
added a commit
that referenced
this pull request
Feb 17, 2022
Signed-off-by: James Elias Sigurdarson <jamiees2@gmail.com> 0db64b5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this will fix #30, the problem is that even though we catch errors above, we still technically have a promise that rejects there.