fix(client): Fix a bug where it causes Node process to crash when calling emit(), disconnect() and connect() in quick succession
#34
Conversation
raytung
force-pushed
the
fix/connect-crash
branch
from
d20b86c to
973ffc4
Compare
…ling `emit()`, `disconnect()` and `connect()` in quick succession Signed-off-by: Ray Tung <ray@kasada.io>
raytung
force-pushed
the
fix/connect-crash
branch
from
973ffc4 to
6f84b6b
Compare
There was a problem hiding this comment.
Hey! sorry about getting such a late start on this :( I was going to try to get this in before my vacation, but was unable to, and didn't really have internet while I was on vacation :)
Anyway, this LGTM, thanks for fixing! I'm going to work on #32 during the weekend, and then once I get that done, I'll cut a new release, if that's OK with you :) Let me know if you want a release for this sooner and I can push it out
| await awaitNextTick(); | ||
| await new Promise(resolve => | ||
| this.once(FluentSocketEvent.CLOSE, resolve) | ||
| ); |
There was a problem hiding this comment.
huh, I wonder why I didn't just do this in the first place 🤷 I guess I read somewhere in the node docs that it will be disconnected by the next tick? not sure where I got that from.
|
@jamiees2 No worries, it's important to take breaks and have holidays 😄 Thanks for taking a look at this. |
|
Released in v1.0.8 :) |
2 participants
Fixes #33.