Fix msgpack str protocol parsing #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Elias Sigurdarson <jamiees2@gmail.com>
github-actions bot
added a commit
that referenced
this pull request
Jun 6, 2022
Signed-off-by: James Elias Sigurdarson <jamiees2@gmail.com> e8ce81b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the protocol as sent by FluentD. When data is sent in the msgpack
strformat, the data ends up getting deserialized as UTF8 in@msgpack/msgpack. When this happens, the data is mangled irreversibly, as@msgpack/msgpackexpects UTF8 formatted data. This adds a lazy hack to instead just parse as a buffer when the buffer starts with either0x92- fixarr of size 2, or0x1f, compressed buffer.Fixes #37
Signed-off-by: James Elias Sigurdarson jamiees2@gmail.com