fix(socket): TLS connection correctly times out #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ray Tung <ray@kasada.io>
raytung
force-pushed
the
timeout-on-tls
branch
from
324a5e8 to
f9fedbd
Compare
jamiees2
approved these changes
Sep 17, 2022
github-actions bot
added a commit
that referenced
this pull request
Sep 17, 2022
Signed-off-by: Ray Tung <ray@kasada.io> Signed-off-by: Ray Tung <ray@kasada.io> d47af4c
|
Published in v1.0.10 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @jamiees2 - we found a funny one with the
timeoutsetting. Turns out we were only passing thetimeoutsetting to non-TLS connections. Would appreciate it if you could take a look at this one. Thanks!