Skip to content

Conversation

@deveshk0
Copy link
Contributor

This PR add supports for imagePullSecrets for FluentBit Daemonset.

issue - #92

@benjaminhuo
Copy link
Member

Some changes are overlapping with #93

@deveshk0
Copy link
Contributor Author

I guess #93 is limited to operator and this introdues changes for daemonset

@wenchajun
Copy link
Member

Thanks a lot. This may need to be revised as well(fluentbit-operator/api/fluentbitoperator/v1alpha2/zz_generated.deepcopy.go )
like this

if in.ImagePullSecrets != nil {
in, out := &in.ImagePullSecrets, &out.ImagePullSecrets
*out = make([]v1.LocalObjectReference, len(*in))
copy(*out, *in)
}

@deveshk0
Copy link
Contributor Author

ohh I thought It was auto-generated. I will update

@deveshk0
Copy link
Contributor Author

@wenchajun I have updated it, Can you please have a look?

@wanjunlei
Copy link
Collaborator

wanjunlei commented Jul 19, 2021

You need to run make manifests and update the files.

@deveshk0
Copy link
Contributor Author

@wanjunlei Updated files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants