Skip to content

Conversation

@okkez
Copy link
Collaborator

@okkez okkez commented Aug 10, 2018

If grok_name_key is specified, parsed records will include the key which is
name (defined by grok.name) or index.

Close #50

okkez added 5 commits August 10, 2018 12:12
If grok_name_key is specified, parsed records will include the key
which is name (defined by grok.name) or index.

Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Because Hash#compact! has been added since Ruby 2.4.0

Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
@cjcc1
Copy link

cjcc1 commented Aug 10, 2018

I'm no ruby dev, but I'll make an attempt at trying it out on my actual system and let you know how it goes.

The docs seem fairly straightforward at least.

Copy link

@cjcc1 cjcc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work - but matching seems affected a little bit. I'll keep playing with it, though.

@okkez
Copy link
Collaborator Author

okkez commented Aug 15, 2018

Thank you for confirming this PR.

@okkez okkez merged commit f2d9f1f into master Aug 15, 2018
@okkez okkez deleted the grok_name_key branch August 15, 2018 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants