Use String#sub instead of String#sub! #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because String#sub! is a destructive method. Built-in in_tail plugin will configure the parse section twice. The in_tail plugin will use raw parse section at the 1st time and it will use parse section with expanded grok pattern without types. We can avoid this behavior when we stop using a destructive method to expand grok patterns. Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Signed-off-by: Kenji Okimoto <okimoto@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because String#sub! is a destructive method.
Built-in in_tail plugin will configure the parse section twice.
The in_tail plugin will use raw parse section at the 1st time and it
will use parse section with expanded grok pattern without types.
We can avoid this behavior when we stop using a destructive method to
expand grok patterns.
Fix #63