refactor(gas): adjust FUEL_DENOM_RATE to reflect actual performance #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportCongrats! CodSpeed is installed 🎉
You will start to see performance impacts in the reports once the benchmarks are run from your default branch.
|
d1r1
force-pushed
the
v82-patched
branch
3 times, most recently
from
02cd9a7 to
c170628
Compare
…atio Context: Benchmarks show WASM instructions are ~20x faster than EVM instructions, not 1000x as originally estimated Change: Updated FUEL_DENOM_RATE from 1000 to 20 to align with measured performance characteristics Rationale: Original 1000:1 ratio was placeholder value. New 20:1 ratio based on empirical benchmarking maintains gas equivalence with EVM while accurately reflecting execution costs Verification: All fuel cost constants in fuel_procedure.rs scaled proportionally (divided by 50). Test assertions updated to expect new gas consumption values BREAKING CHANGE: Existing WASM contracts with explicit ConsumeFuel() calls will consume 50x more gas per unit of fuel. System builtin operations remain gas-equivalent to EVM
Context: FUEL_DENOM_RATE was duplicated between fluentbase and revm. Testnet uses legacy rate (1000), correct rate is 20. Change: Removed FUEL_DENOM_RATE constant from interpreter. Inlined fuel denomination logic in handler/validation.rs with 'fluent-testnet' feature for conditional compilation. Deleted unused Gas methods record_denominated_cost() and record_denominated_refund(). Added cfg-if dependency. Rationale: Eliminates constant duplication - fluentbase remains source of truth. Feature flag enables testnet backward compatibility while defaulting to correct rate for new deployments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Benchmarks show WASM instructions are ~20x faster than EVM instructions, not 1000x as originally estimated
Change: Updated FUEL_DENOM_RATE from 1000 to 20 to align with measured performance characteristics
Rationale: Original 1000:1 ratio was placeholder value. New 20:1 ratio based on empirical benchmarking maintains gas equivalence with EVM while accurately reflecting execution costs
Verification: All fuel cost constants in fuel_procedure.rs scaled proportionally (divided by 50). Test assertions updated to expect new gas consumption values
BREAKING CHANGE: Existing WASM contracts with explicit ConsumeFuel() calls will consume 50x more gas per unit of fuel. System builtin operations remain gas-equivalent to EVM