Fix/use push named for auth flow to preserve navigation stack #144
Conversation
…tion - Replace context.goNamed with context.pushNamed in _RequestCodeView - This change affects both account linking and regular verification flows - The modification ensures a new entry is pushed onto the navigation stack - instead of replacing the current route, changing the navigation behavior
…re stack - Change context.goNamed to context.pushNamed in AuthenticationPage - This modification prevents the authentication page from being replaced - Allows users to navigate back to the authentication page
- Replace context.goNamed with context.pushNamed for account linking request - This change ensures proper navigation stack handling when navigating to the account linking request page
Summary of ChangesHello @fulleni, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a crucial bug fix within the application's authentication flow. The core change involves updating navigation calls from Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a navigation issue by replacing goNamed with pushNamed in the authentication flow. This change ensures the navigation stack is preserved, allowing users to navigate back to previous screens, which is a significant improvement to the user experience. The changes are applied consistently and are in line with the intended use of the go_router package for stack-based navigation. The implementation is clean and effective.
fulleni
deleted the
fix/use-pushNamed-for-auth-flow-to-preserve-navigation-stack
branch
1 participant
Status
READY
Description
This pull request implements a crucial bug fix within the application's authentication flow. The core change involves updating navigation calls from goNamed to pushNamed across key authentication screens. This modification ensures that the navigation stack is properly preserved, allowing users to utilize the back button and navigate through the authentication process as expected, thereby enhancing the user experience.
Type of Change