ElmFlutterView: Destory view instance #381
Conversation
embedding/cpp/elm_flutter_view.cc
Outdated
| } | ||
|
|
||
| evas_object_event_callback_add( | ||
| evas_object_, EVAS_CALLBACK_DEL, |
There was a problem hiding this comment.
When does the object get deleted? By who?
There was a problem hiding this comment.
evas_object_ is deleted when parent_ is deleted.
This deletion is process by Eo of EFL. (ElmFlutterView always needs a valid evas object (parent).)
Of course, if the user deletes FlutterView, I think that another engine problem(crash?) may occur.
I am considering several cases.
JSUYA
force-pushed
the
dev/elmflutterview_shutdown
branch
from
b48f36a to
7e8769b
Compare
|
Q. If the container created inside the view is deleted by some factor of outside, and the view know that event through the callback, should the state of the view be considered valid? +) Should |
JSUYA
force-pushed
the
dev/elmflutterview_shutdown
branch
from
7e8769b to
4eadf71
Compare
JSUYA
force-pushed
the
dev/elmflutterview_shutdown
branch
3 times, most recently
from
c3f7e84 to
b68d257
Compare
embedding/cpp/elm_flutter_view.cc
Outdated
| [](void *data, Evas *evas, Evas_Object *object, void *event_info) { | ||
| auto engine = reinterpret_cast<FlutterDesktopEngineRef>(data); | ||
| if (engine) { | ||
| FlutterDesktopEngineShutdown(engine); |
There was a problem hiding this comment.
I changed it to add view_ destroy call to the destructor.
When ElmFlutterView is deleted, view_ is no longer used, so destory it.
JSUYA
force-pushed
the
dev/elmflutterview_shutdown
branch
from
b68d257 to
3d9d671
Compare
JSUYA
changed the title
|
|
3 participants
When ElmFlutterView is deleted, view_ is no longer used, so destory it.